[PATCH 5/5] fmt_with_err: add a comment that truncation is OK
- From
Jeff King <peff@peff.net>
- Date
- May 19, 2018, 01:58 UTC
- Message-ID
- <20180519015843.GE32492@sigill.intra.peff.net>
- In-Reply-To
- <20180519015444.GA12080@sigill.intra.peff.net>
Functions like die_errno() use fmt_with_err() to combine the caller-provided format with the strerror() string. We use a fixed stack buffer because we're already handling an error and don't have any way to report another one. Our buffer should generally be big enough to fit this, but if it's not, truncation is our best option. Let's add a comment to that effect, so that anybody auditing the code for truncation bugs knows that this is fine.
Signed-off-by: Jeff King <peff@peff.net> --- usage.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/usage.c b/usage.c index cdd534c9df..b3c78931ad 100644 --- a/usage.c +++ b/usage.c @@ -148,6 +148,7 @@ static const char *fmt_with_err(char *buf, int n, const char *fmt) } } str_error[j] = 0; + /* Truncation is acceptable here */ snprintf(buf, n, "%s: %s", fmt, str_error); return buf; }
-- 2.17.0.1052.g7d69f75dbf