Re: [PATCH 3/5] query_fsmonitor: use xsnprintf for formatting integers

From: Jeff King <peff@peff.net>
Date: May 20, 2018, 17:08 UTC
Message-ID: <20180520170814.GB11967@sigill.intra.peff.net>
In-Reply-To: <cd6dba3c-19bb-e6c7-0c1f-5cea0c8f9d81@web.de>

On Sat, May 19, 2018 at 10:27:46AM +0200, René Scharfe wrote:

Show 10 quoted lines

> Am 19.05.2018 um 03:57 schrieb Jeff King:
> > These formatted integers should always fit into their
> > 64-byte buffers. Let's use xsnprintf() to add an assertion
> > that this is the case, which makes auditing for other
> > unchecked snprintfs() easier.
> 
> How about this instead?
> 
> -- >8 --
> Subject: [PATCH] fsmonitor: use internal argv_array of struct child_process

Yeah, I agree that is much nicer (I was so focused on the snprintfs I didn't bother to look at the context for a better solution).

Thanks, getting a review in the form of a complete patch is my favorite kind of review. :)

> Inspired-by: Jeff King <peff@peff.net>

Heh.

-Peff