git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Bug: format-patch MIME boundary not added to cover letter when attach enabled

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Apr 30, 2018, 11:59 UTC
Message-ID
<20180430115909.GB13217@genre.crustytoothpaste.net>
In-Reply-To
<xmqqzi1lxte6.fsf@gitster-ct.c.googlers.com>
On Mon, Apr 30, 2018 at 12:30:57PM +0900, Junio C Hamano wrote:
Show 7 quoted lines
> Thanks.  It is true that the current output from the tool is corrupt
> mime multi-part, and we need to do something about it.
> 
> I however have to wonder if it even makes sense for --cover to pay
> attention to --attach and produce the cover template that has "BLURB
> HERE" etc.  in a multi-part format.  Shouldn't we be making a simple
> plain text file instead?

I agree that multipart/mixed is not a useful content-type for only one plain text part. I have a patch to add the trailing boundary, but I think you make a good argument that perhaps omitting the entire multipart portion would be better.

I'll have to work on this after work, so expect a patch later today.
-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
Previous: Junio C HamanoNext: brian m. carlson
Message 4 of 8 in “Bug: format-patch MIME boundary not added to cover letter when attach enabled”
  1. Patrick HemmerApr 30, 2018
  2. brian m. carlsonApr 30, 2018
  3. Junio C HamanoApr 30, 2018
  4. brian m. carlsonApr 30, 2018
  5. format-patch: make cover letters always text/plainbrian m. carlson, May 1, 2018
  6. Eric SunshineMay 1, 2018
  7. brian m. carlsonMay 2, 2018
  8. format-patch: make cover letters always text/plainbrian m. carlson, May 2, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.