From: brian m. carlson Date: Mon, 30 Apr 2018 11:59:09 GMT Subject: Re: Bug: format-patch MIME boundary not added to cover letter when attach enabled Message-ID: <20180430115909.GB13217@genre.crustytoothpaste.net> In-Reply-To: On Mon, Apr 30, 2018 at 12:30:57PM +0900, Junio C Hamano wrote: > Thanks. It is true that the current output from the tool is corrupt > mime multi-part, and we need to do something about it. > > I however have to wonder if it even makes sense for --cover to pay > attention to --attach and produce the cover template that has "BLURB > HERE" etc. in a multi-part format. Shouldn't we be making a simple > plain text file instead? I agree that multipart/mixed is not a useful content-type for only one plain text part. I have a patch to add the trailing boundary, but I think you make a good argument that perhaps omitting the entire multipart portion would be better. I'll have to work on this after work, so expect a patch later today. -- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204