git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Bug: format-patch MIME boundary not added to cover letter when attach enabled

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 30, 2018, 03:30 UTC
Message-ID
<xmqqzi1lxte6.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20180430020930.GA13217@genre.crustytoothpaste.net>
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
Show 9 quoted lines
> On Sun, Apr 29, 2018 at 09:40:13PM -0400, Patrick Hemmer wrote:
>> When you use `git format-patch --cover-letter --attach`, the cover
>> letter does not have the trailing MIME boundary. RFC2046 states that the
>> last part must be followed by a closing boundary. This causes some email
>> clients (Thunderbird in my case) to discard the message body.
>> This is experienced with git 2.16.3.
>
> Thanks for reporting this.  I can confirm this with a reasonably recent
> next.  Let me see if I can come up with a patch.

Thanks. It is true that the current output from the tool is corrupt mime multi-part, and we need to do something about it.

I however have to wonder if it even makes sense for --cover to pay attention to --attach and produce the cover template that has "BLURB HERE" etc. in a multi-part format. Shouldn't we be making a simple plain text file instead?

Previous: brian m. carlsonNext: brian m. carlson
Message 3 of 8 in “Bug: format-patch MIME boundary not added to cover letter when attach enabled”
  1. Patrick HemmerApr 30, 2018
  2. brian m. carlsonApr 30, 2018
  3. Junio C HamanoApr 30, 2018
  4. brian m. carlsonApr 30, 2018
  5. format-patch: make cover letters always text/plainbrian m. carlson, May 1, 2018
  6. Eric SunshineMay 1, 2018
  7. brian m. carlsonMay 2, 2018
  8. format-patch: make cover letters always text/plainbrian m. carlson, May 2, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.