Re: Consequences of CRLF in index?

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Oct 26, 2017, 20:30 UTC
Message-ID: <20171026203046.fu3z5ngnw7hckfrn@aiede.mtv.corp.google.com>
In-Reply-To: <7a4396e8-7b97-9ec9-d028-c5ad29042c86@kdbg.org>

Johannes Sixt wrote:

> Am 26.10.2017 um 13:01 schrieb Lars Schneider:

Show 8 quoted lines

>> *     -text
>> *.sh   text eol=lf
>
> Why would that be necessary? I cannot have CRLF in shell scripts etc., not
> even on Windows. (And in addition I do not mind CR in C++ source code.) All
> I want is: Git, please, by all means, do not mess with my files, ever. Isn't
> the simplest way to achieve that to set *nothing* at all? Not even
> core.autocrlf?

That's why Lars suggests "* -text" in .gitattributes. That way, if some user of the repository *does* set core.autocrlf, you still get the "do not mess with my files" semantics you want.

If you control the configuration of all users of the repository, you don't need that, but it doesn't hurt, either.

With that "* -text", you do not need "*.sh text eol=lf", but maybe you'd want it in order to get some warnings when someone changes the line endings by mistake without running tests. (Better to have a culture of running tests, you might say. Fair enough, but as with the other .gitattributes line, it doesn't hurt.)

Jonathan