Re: Consequences of CRLF in index?

From: Lars Schneider <larsxschneider@gmail.com>
Date: Oct 26, 2017, 11:06 UTC
Message-ID: <0B4CDE3E-86E1-4919-980B-048577EDCBEE@gmail.com>
In-Reply-To: <20171025171357.4nk4aj2c4m4b6kl3@aiede.mtv.corp.google.com>

Show 22 quoted lines

> On 25 Oct 2017, at 19:13, Jonathan Nieder <jrnieder@gmail.com> wrote:
> 
> Hi again,
> 
> Lars Schneider wrote:
>>> On 24 Oct 2017, at 20:14, Jonathan Nieder <jrnieder@gmail.com> wrote:
> 
>>> In any event, you also probably want to declare what you're doing
>>> using .gitattributes.  By checking in the files as CRLF, you are
>>> declaring that you do *not* want Git to treat them as text files
>>> (i.e., you do not want Git to change the line endings), so something
>>> as simple as
>>> 
>>> 	* -text
>> 
>> That's sounds good. Does "-text" have any other implications?
>> For whatever reason I always thought this is the way to tell
>> Git that a particular file is binary with the implication that
>> Git should not attempt to diff it.
> 
> No other implications.  You're thinking of "-diff".  There is also a
> shortcut "binary" which simply means "-text -diff".

Yeah. Well, when I read "-text" then I think "no text" and that makes me think "is binary".

> Ideas for wording improvements to gitattributes(5) on this subject?

I think the wording in the docs is good. It is just the "text" keyword that confused me. Maybe this could have been names "eolnorm" and "-eolnorm" or something. But it is too late for that now I guess :-)

Thanks, Lars