Re: [PATCH v2 Outreachy] mru: use double-linked list from list.h

From: Jeff King <peff@peff.net>
Date: Oct 3, 2017, 10:10 UTC
Message-ID: <20171003101029.i6frkaipi5dq5bvr@sigill.intra.peff.net>
In-Reply-To: <CAL21Bmn+-2PwkXtK19fvVw-kEx_nftAx9QwvR=h-B-O-ofTqQQ@mail.gmail.com>

On Mon, Oct 02, 2017 at 12:37:53PM +0300, Оля Тележная wrote:

Show 10 quoted lines

> >> Simplify mru.[ch] and related code by reusing the double-linked list
> >> implementation from list.h instead of a custom one.
> >> This commit is an intermediate step. Our final goal is to get rid of
> >> mru.[ch] at all and inline all logic.
> >
> > Thanks, this version looks correct to me.
> 
> Great! What is better - to complete my application now (and say only
> about this patch) or to complete it in last days (and say about
> everything that I've done. Maybe there would be something new).

I think it's good to get it started now. You can always make changes to it later. And in particular, you should fill out the eligibility section s we can make sure that part is good before going further.

Show 7 quoted lines

> > I think you've done a good job here, and this would count for your
> > Outreachy application's contribution. But if you'd like to do that next
> > step, you are welcome to.
> 
> I was thinking about starting my small research about main task of the
> internship. I could postpone it and end with this task, there's no
> problem for me.

I do think you should spend some time thinking about and researching the main task. I'd hope to see in the applications that the candidate has a sense of the problem space and a realistic plan for approaching the work.

> Or, if someone from the newbies wants to have a small simple task -
> it's a great opportunity for him/her. By the way, I am ready to help
> if he/she will have questions or difficulties.

Wonderful. :) I do hope to get Outreachy interns involve in normal list activities like discussion and review, not just producing their own patches.

> So please make a decision on your own, I will be happy in any scenario.

Why don't we give it a week or so to see if anybody else picks it up.

-Peff