Re: [PATCH v2 Outreachy] mru: use double-linked list from list.h

From: Jeff King <peff@peff.net>
Date: Oct 2, 2017, 08:20 UTC
Message-ID: <20171002082020.c7ravpwgz45osrmz@sigill.intra.peff.net>
In-Reply-To: <0102015ed3e9b1a8-74821a55-aa9a-4e5a-b267-c3d2462e3eed-000000@eu-west-1.amazonses.com>

On Sat, Sep 30, 2017 at 05:51:01PM +0000, Olga Telezhnaya wrote:

> Simplify mru.[ch] and related code by reusing the double-linked list
> implementation from list.h instead of a custom one.
> This commit is an intermediate step. Our final goal is to get rid of
> mru.[ch] at all and inline all logic.

Thanks, this version looks correct to me.

I do think there are a few ugly bits in the result (like that initializer for packed_git_mru :) ), so I'd prefer not to merge this down until we do that final step.

So the big question is: who wants to do it?

I think you've done a good job here, and this would count for your Outreachy application's contribution. But if you'd like to do that next step, you are welcome to.

We could also consider it a #leftoverbits that perhaps some other Outreachy candidate would pick up[1].

In the meantime, Junio, I think we'd want to queue this with the intent to graduate it to "pu" or possibly "next", but not "master". Then if somebody (Olga or another applicant) produces the endgame patch, we can queue it on top and move it further. And if nobody does, I can pick it after the application period is over.

-Peff

[1] For those who find this mail through the archive, there's more
    discussion in this thread:

      https://public-inbox.org/git/CAL21BmnvJSaN+Tnw7Hdc5P5biAnM5dfWR7gX5FrAG1r_D8th=A@mail.gmail.com/