Re: [PATCH Outreachy] mru: use double-linked list from list.h

From: Jeff King <peff@peff.net>
Date: Oct 2, 2017, 08:22 UTC
Message-ID: <20171002082213.bpnhql4rfl523p3t@sigill.intra.peff.net>
In-Reply-To: <CAL21Bmk2oN61CxJA0eju=FtAh2Ei9dLqRMPZKonCND4sC504Sg@mail.gmail.com>

On Sat, Sep 30, 2017 at 09:09:11PM +0300, Оля Тележная wrote:

> I added "v2" after "PATCH", but it does not appeared. Actually it was
> written automatically and it was "PATCH Outreachy v2". I rearranged it
> in the middle of the phrase.

That looks fine.

Show 7 quoted lines

> > I'm not sure what you mean about checking in mru_clear(). It may make
> > sense to just send your v2 patch and I can see there what you do.
> 
> I realized that I said something strange before. I solved the problem
> with leak by deleting INIT in prepare_packed_git and adding init as
> you suggested here:
> https://github.com/telezhnaya/git/commit/7f8995835949f83e54efdfd88445feb6d54cb3e9#commitcomment-24576103

OK, that makes sense.

> By the way, I asked to edit FAQ for Linux kernel newbies about linked
> list that confused me a week ago, and that funny picture was deleted.
> https://kernelnewbies.org/FAQ/LinkedLists
> Maybe it will help to someone else :)

Thank you. :)

Remember (and this applies to other Outreachy folks, too) to submit your application in the Outreachy system:

   https://outreachy.gnome.org

-Peff