git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] diff: correct newline in summary for renamed files

From
Jeff King <peff@peff.net>
Date
Sep 27, 2017, 22:49 UTC
Message-ID
<20170927224909.25dfojhx6wzaqwt7@sigill.intra.peff.net>
In-Reply-To
<CAGZ79kYAfii=vwXwSkx-QE+tXSfPE5h1c39gZSB=c5Asfq9P3Q@mail.gmail.com>
On Wed, Sep 27, 2017 at 03:39:00PM -0700, Stefan Beller wrote:
Show 12 quoted lines
> On Wed, Sep 27, 2017 at 3:32 PM, Jeff King <peff@peff.net> wrote:
> 
> > The most appropriate place seems like t4013. I tried adding to its big
> > list of tested formats, but it's quite fragile. The patch below is what
> > I came up with, but it still needs updated to cover the cases which call
> > "log --all".
> >
> > I think we'd do better to just do a set of new tests at the end (or even
> > a new test script for diffing mode changes in various formats).
> 
> Thanks for providing this patch, I think it is actually reasonable to
> do it here. I can fixup the rest if you don't mind.
OK. Please go ahead, then.
-Peff
Previous: Stefan BellerNext: Stefan Beller
Message 10 of 19 in “diffstat summary mode change bug”
  1. Linus TorvaldsSep 27, 2017
  2. Stefan BellerSep 27, 2017
  3. Linus TorvaldsSep 27, 2017
  4. Stefan BellerSep 27, 2017
  5. diff: correct newline in summary for renamed filesStefan Beller, Sep 27, 2017
  6. Linus TorvaldsSep 27, 2017
  7. Jeff KingSep 27, 2017
  8. Jeff KingSep 27, 2017
  9. Stefan BellerSep 27, 2017
  10. Jeff KingSep 27, 2017
  11. diff: correct newline in summary for renamed filesStefan Beller, Sep 27, 2017
  12. Jonathan NiederSep 27, 2017
  13. Ramsay JonesSep 27, 2017
  14. Stefan BellerSep 27, 2017
  15. Jeff KingSep 28, 2017
  16. Junio C HamanoSep 28, 2017
  17. Jeff KingSep 28, 2017
  18. Stefan BellerSep 27, 2017
  19. Junio C HamanoSep 28, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.