Re: [PATCH] diff: correct newline in summary for renamed files

From: Stefan Beller <sbeller@google.com>
Date: Sep 27, 2017, 22:39 UTC
Message-ID: <CAGZ79kYAfii=vwXwSkx-QE+tXSfPE5h1c39gZSB=c5Asfq9P3Q@mail.gmail.com>
In-Reply-To: <20170927223239.t6gvfztkdjn2vltb@sigill.intra.peff.net>

On Wed, Sep 27, 2017 at 3:32 PM, Jeff King <peff@peff.net> wrote:

Show 7 quoted lines

> The most appropriate place seems like t4013. I tried adding to its big
> list of tested formats, but it's quite fragile. The patch below is what
> I came up with, but it still needs updated to cover the cases which call
> "log --all".
>
> I think we'd do better to just do a set of new tests at the end (or even
> a new test script for diffing mode changes in various formats).

Thanks for providing this patch, I think it is actually reasonable to do it here. I can fixup the rest if you don't mind.