From: Jeff King <peff@peff.net>
Date: Wed, 27 Sep 2017 22:49:10 GMT
Subject: Re: [PATCH] diff: correct newline in summary for renamed files
Message-ID: <20170927224909.25dfojhx6wzaqwt7@sigill.intra.peff.net>
In-Reply-To: <CAGZ79kYAfii=vwXwSkx-QE+tXSfPE5h1c39gZSB=c5Asfq9P3Q@mail.gmail.com>

On Wed, Sep 27, 2017 at 03:39:00PM -0700, Stefan Beller wrote:

> On Wed, Sep 27, 2017 at 3:32 PM, Jeff King <peff@peff.net> wrote:
> 
> > The most appropriate place seems like t4013. I tried adding to its big
> > list of tested formats, but it's quite fragile. The patch below is what
> > I came up with, but it still needs updated to cover the cases which call
> > "log --all".
> >
> > I think we'd do better to just do a set of new tests at the end (or even
> > a new test script for diffing mode changes in various formats).
> 
> Thanks for providing this patch, I think it is actually reasonable to
> do it here. I can fixup the rest if you don't mind.

OK. Please go ahead, then.

-Peff