Re: [PATCH 2/7] notes-merge: drop dead zero-write code

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Sep 25, 2017, 21:59 UTC
Message-ID: <20170925215958.GA27425@aiede.mtv.corp.google.com>
In-Reply-To: <20170925202757.w6eb556kq3ecyks3@sigill.intra.peff.net>

Jeff King wrote:

Show 11 quoted lines

> We call write_in_full() with a size that we know is greater
> than zero. The return value can never be zero, then, since
> write_in_full() converts such a failed write() into ENOSPC
> and returns -1.  We can just drop this branch of the error
> handling entirely.
>
> Suggested-by: Jonathan Nieder <jrnieder@gmail.com>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
>  notes-merge.c | 2 --
>  1 file changed, 2 deletions(-)

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks for tying up this loose end.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.