From: Jonathan Nieder <jrnieder@gmail.com>
Date: Mon, 25 Sep 2017 21:59:58 GMT
Subject: Re: [PATCH 2/7] notes-merge: drop dead zero-write code
Message-ID: <20170925215958.GA27425@aiede.mtv.corp.google.com>
In-Reply-To: <20170925202757.w6eb556kq3ecyks3@sigill.intra.peff.net>

Jeff King wrote:

> We call write_in_full() with a size that we know is greater
> than zero. The return value can never be zero, then, since
> write_in_full() converts such a failed write() into ENOSPC
> and returns -1.  We can just drop this branch of the error
> handling entirely.
>
> Suggested-by: Jonathan Nieder <jrnieder@gmail.com>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
>  notes-merge.c | 2 --
>  1 file changed, 2 deletions(-)

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks for tying up this loose end.