Re: [PATCH 1/2] for_each_bisect_ref(): don't trim refnames
- From
Jeff King <peff@peff.net>
- Date
- Jun 14, 2017, 09:32 UTC
- Message-ID
- <20170614093242.twipnjncaka2lhyg@sigill.intra.peff.net>
- In-Reply-To
- <20170614092256.c3fmfcokuwbbcvbz@sigill.intra.peff.net>
On Wed, Jun 14, 2017 at 05:22:56AM -0400, Jeff King wrote:
Show 9 quoted lines
> > refs.c | 12 ++++++++++++ > > refs.h | 5 ++++- > > revision.c | 2 +- > > 3 files changed, 17 insertions(+), 2 deletions(-) > > The change itself looks fine to me. > > Since we obviously don't have even a single test for "--bisect", that > might be worth adding.
It turns out we do, but none that actually check that we use the default refnames. So maybe squash this in?
diff --git a/t/t6002-rev-list-bisect.sh b/t/t6002-rev-list-bisect.sh index 3bf2759ea..534903bbd 100755 --- a/t/t6002-rev-list-bisect.sh +++ b/t/t6002-rev-list-bisect.sh @@ -235,4 +235,18 @@ test_sequence "--bisect" # # + +test_expect_success '--bisect can default to good/bad refs' ' + git update-ref refs/bisect/bad c3 && + good=$(git rev-parse b1) && + git update-ref refs/bisect/good-$good $good && + good=$(git rev-parse c1) && + git update-ref refs/bisect/good-$good $good && + + # the only thing between c3 and c1 is c2 + git rev-parse c2 >expect && + git rev-list --bisect >actual && + test_cmp expect actual +' + test_done