Re: [PATCH 0/2] Fix a refname trimming problem in `log --bisect`
- From
Jeff King <peff@peff.net>
- Date
- Jun 14, 2017, 09:24 UTC
- Message-ID
- <20170614092454.7mtaqnvhiho5yslx@sigill.intra.peff.net>
- In-Reply-To
- <cover.1497430232.git.mhagger@alum.mit.edu>
On Wed, Jun 14, 2017 at 11:07:25AM +0200, Michael Haggerty wrote:
Show 7 quoted lines
> Fix the problem in two orthogonal ways: > > 1. Add a new function, `for_each_fullref_in_submodule()`, that doesn't > trim the refnames that it passes to callbacks, and us that instead. > I *think* that this is a strict improvement, though I don't know > the `git log` code well enough to be sure that it won't have bad > side-effects.
I think this is fine, for the reasons I gave elsewhere in the thread.
Show 9 quoted lines
> 2. Relax the "trimming too many characters" check to allow the full > length of the refname to be trimmed away (though not more than > that). > > In an ideal world the second patch shouldn't be necessary, because > this calling pattern is questionable and it might be better that we > learn about any other offenders. But if we'd rather be conservative > and not break any other code that might rely on the old behavior, > patch 2 is my suggestion for how to do it.
My preference would be to hold off on (2) if we can avoid it. It's cleaner, and I think flushing out these kinds of bugs is useful.
-Peff