git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] builtin/log: honor log.decorate

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
May 13, 2017, 02:49 UTC
Message-ID
<20170513024950.qlk5vrdwwsquceyn@genre.crustytoothpaste.net>
In-Reply-To
<CAMMLpeRkVsvp_fzt+bHSQ_F9gsMhYqej_oyqrjhAXsY1xs7=Qw@mail.gmail.com>
On Fri, May 12, 2017 at 07:23:04PM -0600, Alex Henrie wrote:
Show 12 quoted lines
> When I saw Brian's email today, my first thought was "What was I
> thinking?" My mistake was pretty obvious. Then I remembered that when
> I wrote the original patch, I wasn't sure where to set the default
> value, because there were no clear examples in this file. Now that
> we've established a clear precedent for setting the log.decorate
> default (and other defaults like it) in init_log_defaults, I don't
> expect any more problems with log.decorate. And since it's not
> practical to add tests for similar bugs for every command and
> configuration option in Git, we'll just have to be a little more
> vigilant about code review.
> 
> Again, I apologize for the trouble.

Everyone sends a patch that breaks sometimes (I've broken kernel.org's infrastructure). We try hard to avoid it, but we don't always succeed. I appreciate your review on my patch and suggestion on how to improve it, and I hope this won't put you off from further contributions.

-- 
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | https://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: https://keybase.io/bk2204
Previous: Alex HenrieNext: brian m. carlson
Message 10 of 15 in “builtin/log: honor log.decorate”
  1. builtin/log: honor log.decoratebrian m. carlson, May 12, 2017
  2. Alex HenrieMay 12, 2017
  3. brian m. carlsonMay 12, 2017
  4. builtin/log: honor log.decoratebrian m. carlson, May 12, 2017
  5. Alex HenrieMay 12, 2017
  6. Jonathan NiederMay 12, 2017
  7. brian m. carlsonMay 12, 2017
  8. Jonathan NiederMay 12, 2017
  9. Alex HenrieMay 13, 2017
  10. brian m. carlsonMay 13, 2017
  11. brian m. carlsonMay 13, 2017
  12. builtin/log: honor log.decoratebrian m. carlson, May 14, 2017
  13. Junio C HamanoMay 15, 2017
  14. Alex HenrieMay 15, 2017
  15. Jonathan NiederMay 15, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.