git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] builtin/log: honor log.decorate

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
May 13, 2017, 02:41 UTC
Message-ID
<20170513024141.52nazwvnqsvj2af7@genre.crustytoothpaste.net>
In-Reply-To
<20170512234814.GG27400@aiede.svl.corp.google.com>
On Fri, May 12, 2017 at 04:48:14PM -0700, Jonathan Nieder wrote:
Show 8 quoted lines
> Hi,
> 
> brian m. carlson wrote:
> 
> > Does anyone else have views on whether this is good thing to test for?
> 
> I know you don't mean to be rude, but this comes across as a bit of
> a dismissive question.

Sorry, that wasn't my intention, but I see how it could have come off that way. I was trying to solicit other opinions, but did a bad job and implied yours wasn't valuable. I apologize.

Show 6 quoted lines
> > On Fri, May 12, 2017 at 04:32:14PM -0700, Jonathan Nieder wrote:
> 
> In my humble opinion, the bug being subtle makes it especially useful
> to have a test that describes that bug.  That way, if someone is
> refactoring this code later then they know what to watch out for not
> reintroducing.

Okay. I'll reroll with a patch to the tests. I agree that this is rather subtle.

-- 
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | https://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: https://keybase.io/bk2204
Previous: brian m. carlsonNext: brian m. carlson
Message 11 of 15 in “builtin/log: honor log.decorate”
  1. builtin/log: honor log.decoratebrian m. carlson, May 12, 2017
  2. Alex HenrieMay 12, 2017
  3. brian m. carlsonMay 12, 2017
  4. builtin/log: honor log.decoratebrian m. carlson, May 12, 2017
  5. Alex HenrieMay 12, 2017
  6. Jonathan NiederMay 12, 2017
  7. brian m. carlsonMay 12, 2017
  8. Jonathan NiederMay 12, 2017
  9. Alex HenrieMay 13, 2017
  10. brian m. carlsonMay 13, 2017
  11. brian m. carlsonMay 13, 2017
  12. builtin/log: honor log.decoratebrian m. carlson, May 14, 2017
  13. Junio C HamanoMay 15, 2017
  14. Alex HenrieMay 15, 2017
  15. Jonathan NiederMay 15, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.