git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] builtin/log: honor log.decorate

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
May 12, 2017, 23:37 UTC
Message-ID
<20170512233753.rz2g7quews4ny5iq@genre.crustytoothpaste.net>
In-Reply-To
<20170512233214.GE27400@aiede.svl.corp.google.com>
On Fri, May 12, 2017 at 04:32:14PM -0700, Jonathan Nieder wrote:
Show 7 quoted lines
> brian m. carlson wrote:
> 
> > The recent change that introduced autodecorating of refs accidentally
> > broke the ability of users to set log.decorate = false to override it.
> 
> Yikes.  It sounds to me like we need a test to ensure we don't regress
> it again later.

I can add one, but it's going to be a bit odd. The issue is that as far as I can tell, the option is honored only if it's the last one read, so it necessarily has to be in the per-repository configuration.

I'm not sure it makes that much sense to add a test for this case. Do we generally want to write such tests for all config options? I don't suppose it's that common a mistake to make.

Does anyone else have views on whether this is good thing to test for?
-- 
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | https://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: https://keybase.io/bk2204
Previous: Jonathan NiederNext: Jonathan Nieder
Message 7 of 15 in “builtin/log: honor log.decorate”
  1. builtin/log: honor log.decoratebrian m. carlson, May 12, 2017
  2. Alex HenrieMay 12, 2017
  3. brian m. carlsonMay 12, 2017
  4. builtin/log: honor log.decoratebrian m. carlson, May 12, 2017
  5. Alex HenrieMay 12, 2017
  6. Jonathan NiederMay 12, 2017
  7. brian m. carlsonMay 12, 2017
  8. Jonathan NiederMay 12, 2017
  9. Alex HenrieMay 13, 2017
  10. brian m. carlsonMay 13, 2017
  11. brian m. carlsonMay 13, 2017
  12. builtin/log: honor log.decoratebrian m. carlson, May 14, 2017
  13. Junio C HamanoMay 15, 2017
  14. Alex HenrieMay 15, 2017
  15. Jonathan NiederMay 15, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.