git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/2] perf: add function to setup a fresh test repo

From
Jonathan Nieder <jrnieder@gmail.com>
Date
May 10, 2017, 23:30 UTC
Message-ID
<20170510233032.GD28740@aiede.svl.corp.google.com>
In-Reply-To
<20170510225316.31680-2-avarab@gmail.com>
Hi,
Ævar Arnfjörð Bjarmason wrote:
[...]
Show 7 quoted lines
>  # call at least one of these to establish an appropriately-sized repository
> +test_perf_fresh_repo () {
> +	repo="${1:-$TRASH_DIRECTORY}"
> +	"$MODERN_GIT" init -q "$repo" &&
> +	cd "$repo" &&
> +	test_perf_do_repo_symlink_config_
> +}

Unlike the other two variants, wouldn't this leave the cwd inside the new repo?

In other words, I wonder if the commands starting with the 'cd' should be in a subshell.

Thanks and hope that helps, Jonathan

Previous: Ævar Arnfjörð BjarmasonNext: Ævar Arnfjörð Bjarmason
Message 3 of 9 in “perf: show that wildmatch() regressed for pathological cases in v2.0”
  1. 0/2 perf: show that wildmatch() regressed for pathological cases in v2.0Ævar Arnfjörð Bjarmason, May 10, 2017
  2. 1/2 perf: add function to setup a fresh test repoÆvar Arnfjörð Bjarmason, May 10, 2017
  3. Jonathan NiederMay 10, 2017
  4. Ævar Arnfjörð BjarmasonMay 11, 2017
  5. Junio C HamanoMay 11, 2017
  6. Junio C HamanoMay 11, 2017
  7. Ævar Arnfjörð BjarmasonMay 11, 2017
  8. 2/2 perf: add test showing exponential growth in path globbingÆvar Arnfjörð Bjarmason, May 10, 2017
  9. Jonathan NiederMay 10, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.