Re: [PATCH v2 1/2] perf: add function to setup a fresh test repo

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: May 11, 2017, 09:59 UTC
Message-ID: <CACBZZX5gXWLb4oePjC+aCRQ5HsVD8-M9Ao6akgvEKf1+gx-79A@mail.gmail.com>
In-Reply-To: <xmqq8tm3afaa.fsf@gitster.mtv.corp.google.com>

On Thu, May 11, 2017 at 11:55 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 28 quoted lines

> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
>> On Thu, May 11, 2017 at 1:30 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:
>>> Hi,
>>>
>>> Ęvar Arnfjörš Bjarmason wrote:
>>>
>>> [...]
>>>>  # call at least one of these to establish an appropriately-sized repository
>>>> +test_perf_fresh_repo () {
>>>> +     repo="${1:-$TRASH_DIRECTORY}"
>>>> +     "$MODERN_GIT" init -q "$repo" &&
>>>> +     cd "$repo" &&
>>>> +     test_perf_do_repo_symlink_config_
>>>> +}
>>>
>>> Unlike the other two variants, wouldn't this leave the cwd inside the
>>> new repo?
>>>
>>> In other words, I wonder if the commands starting with the 'cd' should
>>> be in a subshell.
>>>
>>> Thanks and hope that helps,
>>
>> Yup, I'll fix that. Thanks for the review & also on the other patch.
>> Will send a v3 with these issues fixed.
>
> Hmph, does v3 actually have this change?

Nope, sent v4 to fix it, sorry: https://public-inbox.org/git/20170511094108.8756-1-avarab@gmail.com/