From: Jonathan Nieder <jrnieder@gmail.com>
Date: Wed, 10 May 2017 23:30:32 GMT
Subject: Re: [PATCH v2 1/2] perf: add function to setup a fresh test repo
Message-ID: <20170510233032.GD28740@aiede.svl.corp.google.com>
In-Reply-To: <20170510225316.31680-2-avarab@gmail.com>

Hi,

Ævar Arnfjörð Bjarmason wrote:

[...]
>  # call at least one of these to establish an appropriately-sized repository
> +test_perf_fresh_repo () {
> +	repo="${1:-$TRASH_DIRECTORY}"
> +	"$MODERN_GIT" init -q "$repo" &&
> +	cd "$repo" &&
> +	test_perf_do_repo_symlink_config_
> +}

Unlike the other two variants, wouldn't this leave the cwd inside the
new repo?

In other words, I wonder if the commands starting with the 'cd' should
be in a subshell.

Thanks and hope that helps,
Jonathan