git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] cache-tree: reject entries with null sha1

From
Jeff King <peff@peff.net>
Date
May 1, 2017, 21:26 UTC
Message-ID
<20170501212656.h4vhkstjolh46whe@sigill.intra.peff.net>
In-Reply-To
<456378ba-a117-8003-eea2-69272ed9bb58@web.de>
On Mon, May 01, 2017 at 11:00:58PM +0200, René Scharfe wrote:
Show 11 quoted lines
> Am 01.05.2017 um 21:22 schrieb Jeff King:
> > On Mon, May 01, 2017 at 01:23:28PM +0200, René Scharfe wrote:
> > > I can only get gcc and clang to call memcpy instead of inlining it by
> > > specifying -fno-builtin.  Do you use that option?  If yes, why?  (Just
> > > curious.)
> > 
> > I do my normal edit-compile cycles with -O0 because it's fast, and
> > because it makes debugging much easier.
> 
> GCC and Clang still inline memcpy with -O0 alone (at least the versions
> I tested).

I just checked the assembler output and confirmed that is the case for my builds, even with -O0. Which probably explains why I wasn't able to replicate Duy's valgrind error in the first place.

-Peff
Previous: René ScharfeNext: Duy Nguyen
Message 8 of 10 in “cache-tree: reject entries with null sha1”
  1. cache-tree: reject entries with null sha1Jeff King, Apr 21, 2017
  2. Duy NguyenApr 24, 2017
  3. Jeff KingApr 24, 2017
  4. René ScharfeMay 1, 2017
  5. René ScharfeMay 1, 2017
  6. Jeff KingMay 1, 2017
  7. René ScharfeMay 1, 2017
  8. Jeff KingMay 1, 2017
  9. Duy NguyenMay 3, 2017
  10. René ScharfeMay 3, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.