From: Jeff King <peff@peff.net>
Date: Mon, 01 May 2017 21:26:56 GMT
Subject: Re: [PATCH] cache-tree: reject entries with null sha1
Message-ID: <20170501212656.h4vhkstjolh46whe@sigill.intra.peff.net>
In-Reply-To: <456378ba-a117-8003-eea2-69272ed9bb58@web.de>

On Mon, May 01, 2017 at 11:00:58PM +0200, René Scharfe wrote:

> Am 01.05.2017 um 21:22 schrieb Jeff King:
> > On Mon, May 01, 2017 at 01:23:28PM +0200, René Scharfe wrote:
> > > I can only get gcc and clang to call memcpy instead of inlining it by
> > > specifying -fno-builtin.  Do you use that option?  If yes, why?  (Just
> > > curious.)
> > 
> > I do my normal edit-compile cycles with -O0 because it's fast, and
> > because it makes debugging much easier.
> 
> GCC and Clang still inline memcpy with -O0 alone (at least the versions
> I tested).

I just checked the assembler output and confirmed that is the case for
my builds, even with -O0. Which probably explains why I wasn't able to
replicate Duy's valgrind error in the first place.

-Peff