Re: [PATCH] rebase -i: add config to abbreviate command name

From: Jeff King <peff@peff.net>
Date: Apr 24, 2017, 12:29 UTC
Message-ID: <20170424122911.5mvftamplokwctbr@sigill.intra.peff.net>
In-Reply-To: <20170424032347.10878-1-liambeguin@gmail.com>

On Sun, Apr 23, 2017 at 11:23:47PM -0400, Liam Beguin wrote:

> Add the 'rebase.abbrevCmd' boolean config option to allow
> the user to abbreviate the default command name while editing
> the 'git-rebase-todo' file.

Just reading this, I was confused about what the patch actually did. Reading the code, I figured it out, but perhaps an example would make sense. Like:

  This means that we will print:

    p 1234abcd subject line

  in the todo file rather than:

    pick 1234abcd subject line

And then of course that left me wondering why somebody would want to do that. I understand wanting to _type_ the abbreviated version, but surely it's not too much work to read the full word?

Then I saw:

Show 5 quoted lines

> ---
> Notes:
> 
>  *  This allows the lines to remain aligned when using single
>     letter commands.

That makes some sense. it should probably be part of the commit message, so that future readers of "git log" understand why the change was made.

Show 10 quoted lines

> diff --git a/Documentation/config.txt b/Documentation/config.txt
> index 475e874d5155..59b64832aeb4 100644
> --- a/Documentation/config.txt
> +++ b/Documentation/config.txt
> @@ -2614,6 +2614,9 @@ rebase.instructionFormat::
>  	the instruction list during an interactive rebase.  The format will automatically
>  	have the long commit hash prepended to the format.
>  
> +rebase.abbrevCmd::
> +	If set to true, abbreviate command name in interactive mode.

Similar to the commit message, this might need to go into more detail. It was not immediately obvious to me that "command name" means the command-names in the instruction list.

-Peff