Re: [PATCH] t6500: don't run detached auto gc at the end of the test script
On Thu, Apr 20, 2017 at 06:42:59PM +0200, SZEDER Gábor wrote:
Show 9 quoted lines
> > I suppose so. It might be worth being picky just on the principle that
> > if it _is_ gone that's unexpected and we'd prefer somebody notice and
> > figure out why.
>
> OK, agreed.
>
> However, we do need the above 'test -d' for this to work, because 'rm
> -rf' doesn't consider non-existing paths as errors, so we wouldn't
> notice that the trash directory is already gone.
Show 5 quoted lines
> >> > Replacing it the "exit 1" with a "die" that has a message is probably a
> >> > good idea, though.
>
> test-lib.sh has a special 'die', different from git-sh-setup.sh's
> 'die'. I'll use 'error "uh-oh"' instead.
Yeah, sorry, error() is the right function in this instance.
-Peff