Re: [PATCH] t6500: don't run detached auto gc at the end of the test script

From: Jeff King <peff@peff.net>
Date: Apr 13, 2017, 17:57 UTC
Message-ID: <20170413175701.5ogpe7qbflbkgljm@sigill.intra.peff.net>
In-Reply-To: <CAGZ79kY6TmEV38NkYJwkb5=Bu69tCjx6k+t6An5_52h8rEo5-Q@mail.gmail.com>

On Thu, Apr 13, 2017 at 10:55:08AM -0700, Stefan Beller wrote:

Show 10 quoted lines

> On Thu, Apr 13, 2017 at 9:37 AM, Jeff King <peff@peff.net> wrote:
> > Ah, OK, that makes more sense. I can detect it reliably by just checking
> >
> >   ! test -d $root/trash*
> >
> > in my stress-test after the test successfully completes.
> 
> Would we want to report such an error from the test suite itself?
> (My line of thinking is that this is a similar issue to broken && chains,
> which we do report).

Yeah, I had a similar thought. I can't think of any reason why it would trigger a false positive, as long as we account for test-failure and the --debug flag properly. I don't think we can just drop the "-f" from the final "rm", because it may be overriding funny permissions left by tests.

-Peff