git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 5/5] t1400: use test_when_finished for cleanup

From
Jeff King <peff@peff.net>
Date
Mar 21, 2017, 01:53 UTC
Message-ID
<20170321015356.3unr3ptwaaerfu2y@sigill.intra.peff.net>
In-Reply-To
<20170321005616.31324-6-kyle@kyleam.com>
On Mon, Mar 20, 2017 at 08:56:16PM -0400, Kyle Meyer wrote:
> Move cleanup lines that occur after test blocks into
> test_when_finished calls within the test bodies.  Don't move cleanup
> lines that seem to be related to mutiple tests rather than a single
> test.

Sounds logical. The patch looks good to me (though I'll admit my eyes may have glazed a little in the middle).

-Peff
Previous: Kyle MeyerNext: Jeff King
Message 12 of 16 in “t1400: modernize style”
  1. 0/5 t1400: modernize styleKyle Meyer, Mar 21, 2017
  2. 1/5 t1400: rename test descriptions to be uniqueKyle Meyer, Mar 21, 2017
  3. Jeff KingMar 21, 2017
  4. 2/5 t1400: set core.logAllRefUpdates in "logged by touch" testsKyle Meyer, Mar 21, 2017
  5. Jeff KingMar 21, 2017
  6. Kyle MeyerMar 22, 2017
  7. 3/5 t1400: use test_path_is_* helpersKyle Meyer, Mar 21, 2017
  8. Jeff KingMar 21, 2017
  9. 4/5 t1400: remove a set of unused output filesKyle Meyer, Mar 21, 2017
  10. Jeff KingMar 21, 2017
  11. 5/5 t1400: use test_when_finished for cleanupKyle Meyer, Mar 21, 2017
  12. Jeff KingMar 21, 2017
  13. Jeff KingMar 21, 2017
  14. Junio C HamanoMar 21, 2017
  15. Kyle MeyerMar 22, 2017
  16. Kyle MeyerMar 22, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.