From: Jeff King Date: Tue, 21 Mar 2017 01:53:56 GMT Subject: Re: [PATCH 5/5] t1400: use test_when_finished for cleanup Message-ID: <20170321015356.3unr3ptwaaerfu2y@sigill.intra.peff.net> In-Reply-To: <20170321005616.31324-6-kyle@kyleam.com> On Mon, Mar 20, 2017 at 08:56:16PM -0400, Kyle Meyer wrote: > Move cleanup lines that occur after test blocks into > test_when_finished calls within the test bodies. Don't move cleanup > lines that seem to be related to mutiple tests rather than a single > test. Sounds logical. The patch looks good to me (though I'll admit my eyes may have glazed a little in the middle). -Peff