git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/5] t1400: rename test descriptions to be unique

From
Kyle Meyer <kyle@kyleam.com>
Date
Mar 21, 2017, 00:56 UTC
Message-ID
<20170321005616.31324-2-kyle@kyleam.com>
In-Reply-To
<20170321005616.31324-1-kyle@kyleam.com>

A few tests share their description with another test. Extend the descriptions to indicate how the tests differ.

Signed-off-by: Kyle Meyer <kyle@kyleam.com>
---
 t/t1400-update-ref.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/t/t1400-update-ref.sh b/t/t1400-update-ref.sh
index 825422341..fde5b98af 100755
--- a/t/t1400-update-ref.sh
+++ b/t/t1400-update-ref.sh
@@ -40,7 +40,7 @@ test_expect_success \
 	"git update-ref $m $A &&
 	 test $A"' = $(cat .git/'"$m"')'
 test_expect_success \
-	"create $m" \
+	"create $m with oldvalue verification" \
 	"git update-ref $m $B $A &&
 	 test $B"' = $(cat .git/'"$m"')'
 test_expect_success "fail to delete $m with stale ref" '
@@ -72,7 +72,7 @@ test_expect_success \
 	"git update-ref HEAD $A &&
 	 test $A"' = $(cat .git/'"$m"')'
 test_expect_success \
-	"create $m (by HEAD)" \
+	"create $m (by HEAD) with oldvalue verification" \
 	"git update-ref HEAD $B $A &&
 	 test $B"' = $(cat .git/'"$m"')'
 test_expect_success "fail to delete $m (by HEAD) with stale ref" '
@@ -307,7 +307,7 @@ $A $B $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL> 1117150260 +0000	Switch
 $B $A $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL> 1117150860 +0000
 EOF
 test_expect_success \
-	"verifying $m's log" \
+	"verifying $m's log (logged by touch)" \
 	"test_cmp expect .git/logs/$m"
 rm -rf .git/$m .git/logs expect
 
@@ -338,7 +338,7 @@ $A $B $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL> 1117150380 +0000	Switch
 $B $A $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL> 1117150980 +0000
 EOF
 test_expect_success \
-	"verifying $m's log" \
+	"verifying $m's log (logged by config)" \
 	'test_cmp expect .git/logs/$m'
 rm -f .git/$m .git/logs/$m expect
 
-- 
2.12.0
Previous: Kyle MeyerNext: Jeff King
Message 2 of 16 in “t1400: modernize style”
  1. 0/5 t1400: modernize styleKyle Meyer, Mar 21, 2017
  2. 1/5 t1400: rename test descriptions to be uniqueKyle Meyer, Mar 21, 2017
  3. Jeff KingMar 21, 2017
  4. 2/5 t1400: set core.logAllRefUpdates in "logged by touch" testsKyle Meyer, Mar 21, 2017
  5. Jeff KingMar 21, 2017
  6. Kyle MeyerMar 22, 2017
  7. 3/5 t1400: use test_path_is_* helpersKyle Meyer, Mar 21, 2017
  8. Jeff KingMar 21, 2017
  9. 4/5 t1400: remove a set of unused output filesKyle Meyer, Mar 21, 2017
  10. Jeff KingMar 21, 2017
  11. 5/5 t1400: use test_when_finished for cleanupKyle Meyer, Mar 21, 2017
  12. Jeff KingMar 21, 2017
  13. Jeff KingMar 21, 2017
  14. Junio C HamanoMar 21, 2017
  15. Kyle MeyerMar 22, 2017
  16. Kyle MeyerMar 22, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.