Re: [PATCH v7 4/6] stash: teach 'push' (and 'create_stash') to honor pathspec

From: Thomas Gummerer <t.gummerer@gmail.com>
Date: Feb 27, 2017, 21:56 UTC
Message-ID: <20170227215627.GB17065@hank>
In-Reply-To: <xmqq60jvwewc.fsf@gitster.mtv.corp.google.com>

On 02/27, Junio C Hamano wrote:

Show 11 quoted lines

> Thomas Gummerer <t.gummerer@gmail.com> writes:
> 
> > +	test -n "$untracked" || git ls-files --error-unmatch -- "$@" >/dev/null || exit 1
> 
> This silent "exit 1" made me scratch my head, but --error-unmatch
> would have already given an error message, like
> 
>     error: pathspec 'no such' did not match any file(s) known to git.
>     Did you forget to 'git add'?
> 
> so that would be OK.

Yeah exactly, the plan was to let --error-unmatch print the error message, as it's better at giving a good error message than we could easily do here I think.

Maybe this deserves a comment so others won't have the same doubts about this line?

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.