Re: [PATCH v5 3/6] stash: refactor stash_create

From: Jeff King <peff@peff.net>
Date: Feb 17, 2017, 23:48 UTC
Message-ID: <20170217234805.glvhyfbxab6nwgb7@sigill.intra.peff.net>
In-Reply-To: <20170217224141.19183-4-t.gummerer@gmail.com>

On Fri, Feb 17, 2017 at 10:41:38PM +0000, Thomas Gummerer wrote:

Show 8 quoted lines

> Refactor the internal stash_create function to use a -m flag for
> specifying the message and -u flag to indicate whether untracked files
> should be added to the stash.
> 
> This makes it easier to pass a pathspec argument to stash_create in the
> next patch.
> 
> The user interface for git stash create stays the same.

Sounds good, but...

Show 10 quoted lines

> diff --git a/Documentation/git-stash.txt b/Documentation/git-stash.txt
> index 2e9cef06e6..d93c47446a 100644
> --- a/Documentation/git-stash.txt
> +++ b/Documentation/git-stash.txt
> @@ -17,6 +17,7 @@ SYNOPSIS
>  	     [-u|--include-untracked] [-a|--all] [<message>]]
>  'git stash' clear
>  'git stash' create [<message>]
> +'git stash' create [-m <message>] [-u|--include-untracked <untracked|all>]
>  'git stash' store [-m|--message <message>] [-q|--quiet] <commit>

Should this hunk be dropped from the manpage, then?

I think there is a similar one in the next patch that adds the "pathspec" argument, and should be dropped, too.

-Peff