Re: [PATCH v5 6/6] stash: allow pathspecs in the no verb form

From: Jeff King <peff@peff.net>
Date: Feb 17, 2017, 23:46 UTC
Message-ID: <20170217234647.bqhzzm533oruhr5e@sigill.intra.peff.net>
In-Reply-To: <20170217224141.19183-7-t.gummerer@gmail.com>

On Fri, Feb 17, 2017 at 10:41:41PM +0000, Thomas Gummerer wrote:

> Now that stash_push is used in the no verb form of stash, allow
> specifying the command line for this form as well.  Always use -- to
> disambiguate pathspecs from other non-option arguments.

I think that makes sense.

> Also make git stash -p an alias for git stash push -p.  This allows
> users to use git stash -p <pathspec>.

And I think of all the options we discussed for handling "-p", I think this one makes the most sense.

It may be worth calling out in the documentation that this is how it works though, so people do not think that:

  git stash -k -p <path>

would work ("git stash -k -p" _does_ happen to work due to the old options-only rule, but I think we should advertise the general form as "-p is an alias for "push -p").

-Peff