git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] format-patch: Add --rfc for the common case of [RFC PATCH]

From
Jeff King <peff@peff.net>
Date
Sep 17, 2016, 18:43 UTC
Message-ID
<20160917184304.w7lzzsi7pxpnh5sr@sigill.intra.peff.net>
In-Reply-To
<b5bf39015fdd20dd0aa4f38eb365bbbd0d07a4ca.1474096535.git-series.josh@joshtriplett.org>
On Sat, Sep 17, 2016 at 12:21:52AM -0700, Josh Triplett wrote:
Show 12 quoted lines
> This provides a shorter and more convenient alias for
> --subject-prefix='RFC PATCH'.
> 
> Includes documentation in the format-patch manpage, and a new test
> covering --rfc.
> 
> Signed-off-by: Josh Triplett <josh@joshtriplett.org>
> ---
> v2:
> - Add documentation to the format-patch manpage
> - Call subject_prefix_callback rather than reimplementing it
> - Update test to move expectations inside

Assuming we want this option, the implementation looks good to me (and I don't have a big opinion the first part of that sentence).

-Peff
Previous: Josh TriplettNext: Andrew Donnellan
Message 2 of 14 in “format-patch: Add --rfc for the common case of [RFC PATCH]”
  1. format-patch: Add --rfc for the common case of [RFC PATCH]Josh Triplett, Sep 17, 2016
  2. Jeff KingSep 17, 2016
  3. Andrew DonnellanSep 19, 2016
  4. Junio C HamanoSep 19, 2016
  5. Josh TriplettSep 19, 2016
  6. Jeff KingSep 19, 2016
  7. Josh TriplettSep 19, 2016
  8. Jacob KellerSep 19, 2016
  9. Josh TriplettSep 19, 2016
  10. Jacob KellerSep 19, 2016
  11. Jeff KingSep 20, 2016
  12. Jeff KingSep 20, 2016
  13. Jacob KellerSep 20, 2016
  14. Jacob KellerSep 19, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.