From: Jeff King <peff@peff.net>
Date: Sat, 17 Sep 2016 18:43:04 GMT
Subject: Re: [PATCH v2] format-patch: Add --rfc for the common case of [RFC PATCH]
Message-ID: <20160917184304.w7lzzsi7pxpnh5sr@sigill.intra.peff.net>
In-Reply-To: <b5bf39015fdd20dd0aa4f38eb365bbbd0d07a4ca.1474096535.git-series.josh@joshtriplett.org>

On Sat, Sep 17, 2016 at 12:21:52AM -0700, Josh Triplett wrote:

> This provides a shorter and more convenient alias for
> --subject-prefix='RFC PATCH'.
> 
> Includes documentation in the format-patch manpage, and a new test
> covering --rfc.
> 
> Signed-off-by: Josh Triplett <josh@joshtriplett.org>
> ---
> v2:
> - Add documentation to the format-patch manpage
> - Call subject_prefix_callback rather than reimplementing it
> - Update test to move expectations inside

Assuming we want this option, the implementation looks good to me (and I
don't have a big opinion the first part of that sentence).

-Peff