git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] pathspec: removed unnecessary function prototypes

From
Jeff King <peff@peff.net>
Date
Sep 14, 2016, 19:23 UTC
Message-ID
<20160914192341.mgpcc35kgmjqunbh@sigill.intra.peff.net>
In-Reply-To
<20160913181552.74bhacoa2q76yv6k@sigill.intra.peff.net>
On Tue, Sep 13, 2016 at 11:15:52AM -0700, Jeff King wrote:
Show 10 quoted lines
> On Tue, Sep 13, 2016 at 09:52:51AM -0700, Brandon Williams wrote:
> 
> > removed function prototypes from pathspec.h which don't have a
> > corresponding implementation.
> 
> I'm always curious of the "why" in cases like this. Did we forget to add
> them? Did they get renamed? Did they go away?
> 
> Looks like the latter; 5a76aff (add: convert to use parse_pathspec,
> 2013-07-14) just forgot to remove them.

I should have done a better job of not just providing the answer, but showing how. The easiest tool here is "git log -S":

  git log -1 -p -Scheck_path_for_gitlink
(and then you can see that the whole function went away there).
-Peff
Previous: Junio C HamanoNext: Brandon Williams
Message 4 of 5 in “pathspec: removed unnecessary function prototypes”
  1. pathspec: removed unnecessary function prototypesBrandon Williams, Sep 13, 2016
  2. Jeff KingSep 13, 2016
  3. Junio C HamanoSep 13, 2016
  4. Jeff KingSep 14, 2016
  5. Brandon WilliamsSep 14, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.