Re: [PATCH] pathspec: removed unnecessary function prototypes

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 13, 2016, 23:08 UTC
Message-ID: <xmqqh99jtn33.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160913181552.74bhacoa2q76yv6k@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 10 quoted lines

> On Tue, Sep 13, 2016 at 09:52:51AM -0700, Brandon Williams wrote:
>
>> removed function prototypes from pathspec.h which don't have a
>> corresponding implementation.
>
> I'm always curious of the "why" in cases like this. Did we forget to add
> them? Did they get renamed? Did they go away?
>
> Looks like the latter; 5a76aff (add: convert to use parse_pathspec,
> 2013-07-14) just forgot to remove them.

Thanks for digging.