From: Jeff King <peff@peff.net>
Date: Wed, 14 Sep 2016 19:23:41 GMT
Subject: Re: [PATCH] pathspec: removed unnecessary function prototypes
Message-ID: <20160914192341.mgpcc35kgmjqunbh@sigill.intra.peff.net>
In-Reply-To: <20160913181552.74bhacoa2q76yv6k@sigill.intra.peff.net>

On Tue, Sep 13, 2016 at 11:15:52AM -0700, Jeff King wrote:

> On Tue, Sep 13, 2016 at 09:52:51AM -0700, Brandon Williams wrote:
> 
> > removed function prototypes from pathspec.h which don't have a
> > corresponding implementation.
> 
> I'm always curious of the "why" in cases like this. Did we forget to add
> them? Did they get renamed? Did they go away?
> 
> Looks like the latter; 5a76aff (add: convert to use parse_pathspec,
> 2013-07-14) just forgot to remove them.

I should have done a better job of not just providing the answer, but
showing how. The easiest tool here is "git log -S":

  git log -1 -p -Scheck_path_for_gitlink

(and then you can see that the whole function went away there).

-Peff