[PATCH 5/8] write_file: use xopen
- From
Jeff King <peff@peff.net>
- Date
- Jul 8, 2016, 09:10 UTC
- Message-ID
- <20160708091007.GE10152@sigill.intra.peff.net>
- In-Reply-To
- <20160708090400.GA26594@sigill.intra.peff.net>
This simplifies the code a tiny bit, and provides consistent error messages with other users of xopen().
While we're here, let's also switch to using O_WRONLY. We know we're only going to open/write/close the file, so there's no point in asking for O_RDWR.
Signed-off-by: Jeff King <peff@peff.net> --- wrapper.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/wrapper.c b/wrapper.c index 0349441..7c126b8 100644 --- a/wrapper.c +++ b/wrapper.c @@ -644,9 +644,7 @@ void write_file(const char *path, const char *fmt, ...) { va_list params; struct strbuf sb = STRBUF_INIT; - int fd = open(path, O_RDWR | O_CREAT | O_TRUNC, 0666); - if (fd < 0) - die_errno(_("could not open %s for writing"), path); + int fd = xopen(path, O_WRONLY | O_CREAT | O_TRUNC, 0666); va_start(params, fmt); strbuf_vaddf(&sb, fmt, params);
-- 2.9.0.393.g704e522