Re: [PATCH 2/2] fsck: detect and warn a commit with embedded NUL

From: Jeff King <peff@peff.net>
Date: Apr 14, 2016, 18:25 UTC
Message-ID: <20160414182544.GC22068@sigill.intra.peff.net>
In-Reply-To: <20160414182102.GB22068@sigill.intra.peff.net>

On Thu, Apr 14, 2016 at 02:21:03PM -0400, Jeff King wrote:

> So yet another alternative would be to include this check in
> verify_headers(). It would parse to the end of the headers as now, and
> then from there additionally look for a NUL in the body.

Hmm. Looking at verify_headers(), I think it has another bug.

It wants to "return report(...)" as soon as it sees a problem, and stops looking for other ones. But the new model for reporting errors is that report() might ignore a problem if configured to do so.

So I think if you were to ignore NUL_IN_HEADER, then a commit with NUL_IN_HEADER could still pass fsck, even though it should trigger UNTERMINATED_HEADER.

-Peff