Re: [PATCH 2/2] fsck: detect and warn a commit with embedded NUL

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Apr 15, 2016, 13:43 UTC
Message-ID: <alpine.DEB.2.20.1604151541580.2967@virtualbox>
In-Reply-To: <20160414180709.28968-2-gitster@pobox.com>

Hi Junio,

On Thu, 14 Apr 2016, Junio C Hamano wrote:

Show 10 quoted lines

> Even though a Git commit object is designed to be capable of storing
> any binary data as its payload, in practice people use it to describe
> the changes in textual form, and tools like "git log" are designed to
> treat the payload as text.
> 
> Detect and warn when we see any commit object with a NUL byte in
> it.
> 
> Note that a NUL byte in the header part is already detected as a
> grave error.  This change is purely about the message part.

IIRC there was some discussion going on about this, and since it was 1) legal and 2) not checked before, I decided not to make this an error.

But of course it is good to introduce a warning!

Thank you, Dscho