git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 1/3] submodule: add test to demonstrate that shallow recursive clones fail

From
Jeff King <peff@peff.net>
Date
Mar 20, 2016, 19:40 UTC
Message-ID
<20160320194049.GA6288@sigill.intra.peff.net>
In-Reply-To
<0767AEDB-36D6-45BE-A1CC-944ECAFC00FB@gmail.com>
On Sun, Mar 20, 2016 at 06:05:34PM +0100, Lars Schneider wrote:
Show 7 quoted lines
> >> +test_expect_failure shallow-clone-recursive '
> >> +       URL="file://$(pwd | sed "s/[[:space:]]/%20/g")/repo" &&
> > 
> > This would break if the test suite is in a path containing any other white space
> > than U+0020 such as a tab? (Not that I am encouraging using such paths...)
> True. I wonder if we really need to use the "file://" URL format here. Maybe
> a relative would be easier?!

I did not look closely at the patch or the tests, but generally we skip shallow-cloning for local-path repositories, as we don't do a regular object transfer at all (and we turn that optimization off for file:// URLs). So presumably it would defeat the purpose of the test.

-Peff
Previous: Lars SchneiderNext: Stefan Beller
Message 6 of 14 in “add test to demonstrate that shallow recursive clones fail”
  1. 0/3 add test to demonstrate that shallow recursive clones faillarsxschneider@gmail.com, Dec 20, 2015
  2. 1/3 submodule: add test to demonstrate that shallow recursive clones faillarsxschneider@gmail.com, Dec 20, 2015
  3. Stefan BellerMar 15, 2016
  4. Junio C HamanoMar 15, 2016
  5. Lars SchneiderMar 20, 2016
  6. Jeff KingMar 20, 2016
  7. Stefan BellerMar 20, 2016
  8. 2/3 submodule: fix &&-chain breakagelarsxschneider@gmail.com, Dec 20, 2015
  9. 3/3 submodule: extend die message on failed checkout with depth argumentlarsxschneider@gmail.com, Dec 20, 2015
  10. Stefan BellerJan 11, 2016
  11. Lars SchneiderJan 12, 2016
  12. Stefan BellerJan 12, 2016
  13. Lars SchneiderJan 7, 2016
  14. Stefan BellerJan 11, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.