Re: [PATCH v3 1/3] submodule: add test to demonstrate that shallow recursive clones fail

From: Lars Schneider <larsxschneider@gmail.com>
Date: Mar 20, 2016, 17:05 UTC
Message-ID: <0767AEDB-36D6-45BE-A1CC-944ECAFC00FB@gmail.com>
In-Reply-To: <CAGZ79kYzbmzK1UwvWheugkqG0FwhpGMU0_K_jyCKOnoKb5oTxQ@mail.gmail.com>

On 15 Mar 2016, at 20:50, Stefan Beller <sbeller@google.com> wrote:

Show 9 quoted lines

> On Sun, Dec 20, 2015 at 3:19 PM,  <larsxschneider@gmail.com> wrote:
>> From: Lars Schneider <larsxschneider@gmail.com>
>> 
>> "git clone --recursive --depth 1 --single-branch <url>" clones the
>> submodules successfully. However, it does not obey "--depth 1" for
>> submodule cloning.
> 
> I am about to resend "[RFC/PATCH] clone: add `--shallow-submodules` flag"
> which would need tests and I thought about this series as tests.

Sounds good, thanks!

> I assume patch 2 (fixing a broken && chain in tests) made it through,
> but patch 1 and 3 did not? I may pick up ideas from here as it will be
> slightly different tests I'd guess.

Unfortunately patch 2 ($gmane/282776) did not made it in (I just checked next 104e649). How should we proceed?

Show 7 quoted lines

> 
> 
>> +test_expect_failure shallow-clone-recursive '
>> +       URL="file://$(pwd | sed "s/[[:space:]]/%20/g")/repo" &&
> 
> This would break if the test suite is in a path containing any other white space
> than U+0020 such as a tab? (Not that I am encouraging using such paths...)

True. I wonder if we really need to use the "file://" URL format here. Maybe a relative would be easier?!

Thanks, Lars