From: Jeff King <peff@peff.net>
Date: Sun, 20 Mar 2016 19:40:50 GMT
Subject: Re: [PATCH v3 1/3] submodule: add test to demonstrate that shallow recursive clones fail
Message-ID: <20160320194049.GA6288@sigill.intra.peff.net>
In-Reply-To: <0767AEDB-36D6-45BE-A1CC-944ECAFC00FB@gmail.com>

On Sun, Mar 20, 2016 at 06:05:34PM +0100, Lars Schneider wrote:

> >> +test_expect_failure shallow-clone-recursive '
> >> +       URL="file://$(pwd | sed "s/[[:space:]]/%20/g")/repo" &&
> > 
> > This would break if the test suite is in a path containing any other white space
> > than U+0020 such as a tab? (Not that I am encouraging using such paths...)
> True. I wonder if we really need to use the "file://" URL format here. Maybe
> a relative would be easier?!

I did not look closely at the patch or the tests, but generally we skip
shallow-cloning for local-path repositories, as we don't do a regular
object transfer at all (and we turn that optimization off for file://
URLs). So presumably it would defeat the purpose of the test.

-Peff