git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rebase -p: avoid grep on potentailly non-ASCII data

From
Jeff King <peff@peff.net>
Date
Mar 8, 2016, 14:35 UTC
Message-ID
<20160308143556.GA10153@sigill.intra.peff.net>
In-Reply-To
<56DED770.4050603@drmicha.warpmail.net>
On Tue, Mar 08, 2016 at 02:45:20PM +0100, Michael J Gruber wrote:
Show 6 quoted lines
> It may be worth noting whether other occurrences of "sane_grep" are safe
> from binary input.
> 
> After all, one my question the degree of sanity of our sane_grep, or
> whether we need asane_grep and bisane_grep in our shell library - "make
> our grep sane again".

I actually wonder if we should have a build-time knob to put "grep -a" into sane_grep(). We do not ever plan to feed it binary data, so that will do what, provided the system grep handles "-a". And on those that do not know about "-a", one imagines that they do not suffer from this problem in the first place (which is really limited to recent versions of GNU grep).

-Peff
Previous: Michael J GruberNext: Junio C Hamano
Message 4 of 12 in “rebase -p: avoid grep on potentailly non-ASCII data”
  1. rebase -p: avoid grep on potentailly non-ASCII dataAnders Kaseorg, Mar 8, 2016
  2. Torsten BögershausenMar 8, 2016
  3. Michael J GruberMar 8, 2016
  4. Jeff KingMar 8, 2016
  5. Junio C HamanoMar 8, 2016
  6. Junio C HamanoMar 8, 2016
  7. Jeff KingMar 9, 2016
  8. Jeff KingMar 9, 2016
  9. Anders KaseorgMar 9, 2016
  10. Junio C HamanoMar 9, 2016
  11. Torsten BögershausenMar 10, 2016
  12. Junio C HamanoMar 10, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.