Re: [PATCH] rebase -p: avoid grep on potentailly non-ASCII data

From: Anders Kaseorg <andersk@mit.edu>
Date: Mar 9, 2016, 02:31 UTC
Message-ID: <alpine.DEB.2.10.1603082127230.2674@buzzword-bingo.mit.edu>
In-Reply-To: <xmqqio0wk151.fsf@gitster.mtv.corp.google.com>

The autoconf support you committed as 67f1790a has a small bug (the else cause should omit -a):

+if grep -a ascii configure.ac >/dev/null; then
+  AC_MSG_RESULT([Using 'grep -a' for sane_grep])
+  SANE_TEXT_GREP=-a
+else
+  SANE_TEXT_GREP=-a
+fi
+GIT_CONF_SUBST([SANE_TEXT_GREP])

Anders