From: Jeff King <peff@peff.net>
Date: Tue, 08 Mar 2016 14:35:56 GMT
Subject: Re: [PATCH] rebase -p: avoid grep on potentailly non-ASCII data
Message-ID: <20160308143556.GA10153@sigill.intra.peff.net>
In-Reply-To: <56DED770.4050603@drmicha.warpmail.net>

On Tue, Mar 08, 2016 at 02:45:20PM +0100, Michael J Gruber wrote:

> It may be worth noting whether other occurrences of "sane_grep" are safe
> from binary input.
> 
> After all, one my question the degree of sanity of our sane_grep, or
> whether we need asane_grep and bisane_grep in our shell library - "make
> our grep sane again".

I actually wonder if we should have a build-time knob to put "grep -a"
into sane_grep(). We do not ever plan to feed it binary data, so that
will do what, provided the system grep handles "-a". And on those that
do not know about "-a", one imagines that they do not suffer from this
problem in the first place (which is really limited to recent versions
of GNU grep).

-Peff