git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] t5510: do not leave changed cwd

From
Jeff King <peff@peff.net>
Date
Mar 4, 2016, 11:52 UTC
Message-ID
<20160304115255.GB8355@sigill.intra.peff.net>
In-Reply-To
<f6499302a5dfb52bf6c9430581103da9569434a3.1457088499.git.git@drmicha.warpmail.net>
On Fri, Mar 04, 2016 at 11:53:50AM +0100, Michael J Gruber wrote:
> t5510 carefully keeps the cwd at the test root by using either subshells
> or explicit cd'ing back to the root. Use a subshell for the last
> subtest, too.

I doubt this caused the heisenbug you saw, as we should have an absolute path for the trash-dir, and we "cd" to its containing directory before deleting it. But this is definitely a good thing to be doing anyway, to prevent surprises for new tests added to t5510.

-Peff
Previous: Michael J GruberNext: Michael J Gruber
Message 7 of 9 in “Test trash dir sanitizing”
  1. 0/2 Test trash dir sanitizingMichael J Gruber, Mar 4, 2016
  2. 1/2 test-lib: quote TRASH_DIRECTORYMichael J Gruber, Mar 4, 2016
  3. Jeff KingMar 4, 2016
  4. Michael J GruberMar 4, 2016
  5. Jeff KingMar 4, 2016
  6. 2/2 t5510: do not leave changed cwdMichael J Gruber, Mar 4, 2016
  7. Jeff KingMar 4, 2016
  8. Michael J GruberMar 4, 2016
  9. Junio C HamanoMar 4, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.