git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] test-lib: quote TRASH_DIRECTORY

From
Michael J Gruber <git@drmicha.warpmail.net>
Date
Mar 4, 2016, 10:53 UTC
Message-ID
<a07529d116612bcd1c411a697f8f8e37d7c18d3f.1457088499.git.git@drmicha.warpmail.net>
In-Reply-To
<cover.1457088499.git.git@drmicha.warpmail.net>

We always quote $TRASH_DIRECTORY to guard against funky path names. Do so in one more spot

Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
---
 t/test-lib.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/test-lib.sh b/t/test-lib.sh
index 0b47eb6..8957916 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -868,7 +868,7 @@ case "$TRASH_DIRECTORY" in
 /*) ;; # absolute path is good
  *) TRASH_DIRECTORY="$TEST_OUTPUT_DIRECTORY/$TRASH_DIRECTORY" ;;
 esac
-test ! -z "$debug" || remove_trash=$TRASH_DIRECTORY
+test ! -z "$debug" || remove_trash="$TRASH_DIRECTORY"
 rm -fr "$TRASH_DIRECTORY" || {
 	GIT_EXIT_OK=t
 	echo >&5 "FATAL: Cannot prepare test area"
-- 
2.8.0.rc0.181.g163d81c
Previous: Michael J GruberNext: Jeff King
Message 2 of 9 in “Test trash dir sanitizing”
  1. 0/2 Test trash dir sanitizingMichael J Gruber, Mar 4, 2016
  2. 1/2 test-lib: quote TRASH_DIRECTORYMichael J Gruber, Mar 4, 2016
  3. Jeff KingMar 4, 2016
  4. Michael J GruberMar 4, 2016
  5. Jeff KingMar 4, 2016
  6. 2/2 t5510: do not leave changed cwdMichael J Gruber, Mar 4, 2016
  7. Jeff KingMar 4, 2016
  8. Michael J GruberMar 4, 2016
  9. Junio C HamanoMar 4, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.